Add build strict option that builds with the strict type checker#4098
Merged
samelhusseini merged 3 commits intoSep 9, 2020
Merged
Conversation
maribethb
approved these changes
Aug 6, 2020
Collaborator
|
@samelhusseini are you planning to merge this for Q3? |
Contributor
Author
|
Yes, ok to merge now? |
Collaborator
|
I just poked travis. Okay to merge once that passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#4040
Proposed Changes
Adds
npm run build:strictandnpm run build:strict:logto compile with the closure surfacing thestrictTypeCheckererrors.Reason for Changes
Optional for folks that find this beneficial in finding bugs / type issues.
Test Coverage
Tested both new and previous command
npm run build:debugandnpm run build:debug:log.Tested on:
Documentation
Additional Information