Adding async cleanup to tests#4103
Merged
moniika merged 4 commits intoAug 5, 2020
Merged
Conversation
alschmiedt
approved these changes
Aug 4, 2020
| }); | ||
|
|
||
| teardown(function() { | ||
| workspaceTeardown.call(this, this.workspace); |
Contributor
There was a problem hiding this comment.
Could this also go in the parent teardown function?
Contributor
Author
There was a problem hiding this comment.
Can't be moved, parent teardown doesn't have access to this.workspace. Could be moved if this.workspace was re-defined in outer scope, but there's a lot of other similar instances and I'm not yet convinced that's the best plan. See #4080 for more explanation (if I do move things, I'd probably do it as part of addressing that bug).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Part of #4070
Part of #4064
Proposed Changes
sharedTestSetupandsharedTestTeardownto handle running all async Blockly code in teardownworkspaceTeardownin order to handle runnning any async tasks and catching if any error (so remaining tests still run).Reason for Changes
Test Coverage
Ran mocha tests
Tested on:
Additional Information
navigation_modify_test.js,insertion_marker_test.jsandtheme_test.jsnot included in this PR. To be addressed in follow up as there were errors that need to be investigated when shared setup/teardown was tried.