Viewport change event#4180
Merged
moniika merged 13 commits intoSep 1, 2020
Merged
Conversation
moniika
commented
Aug 17, 2020
moniika
commented
Aug 17, 2020
added 7 commits
August 17, 2020 15:13
moniika
marked this pull request as ready for review
August 18, 2020 23:34
rachel-fenichel
approved these changes
Aug 28, 2020
rachel-fenichel
left a comment
rachel-fenichel
left a comment
Collaborator
There was a problem hiding this comment.
Two nits then lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#1052
Proposed Changes
Reason for Changes
Allows for listening for changes to viewport.
Test Coverage
Ran mocha tests.
Tested on:
Additional Information
Planning to implement new event type for viewport changes in separate PR.