Skip to content

Minor stub and assert cleanup#4185

Merged
moniika merged 2 commits into
RaspberryPiFoundation:developfrom
moniika:flip-actual-expected
Aug 20, 2020
Merged

Minor stub and assert cleanup#4185
moniika merged 2 commits into
RaspberryPiFoundation:developfrom
moniika:flip-actual-expected

Conversation

@moniika

@moniika moniika commented Aug 17, 2020

Copy link
Copy Markdown
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

n/a

Proposed Changes

  • Fixes order of actual/expected arguments in assert call
  • Replaces usages of callsFake with returns where approriate

Reason for Changes

  • More accurate assert message
  • Simplifies

Test Coverage

Ran mocha tests.

Tested on:

  • Desktop Chrome

@moniika
moniika force-pushed the flip-actual-expected branch from 7913130 to 374e6a1 Compare August 20, 2020 01:09
@moniika
moniika requested review from alschmiedt and removed request for samelhusseini August 20, 2020 01:13
@moniika
moniika merged commit f849f88 into RaspberryPiFoundation:develop Aug 20, 2020
@moniika
moniika deleted the flip-actual-expected branch August 20, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants