Skip to content

Conversation

@snyff
Copy link

@snyff snyff commented Apr 30, 2019

Since building the binary should be done using a low-privileges account, administrator will need to sudo (or any other way to escalate privileges) to install brotli.

Since building the binary should be done using a low-privileges account, administrator will need to sudo (or any other way to escalate privileges) to install brotli.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@snyff
Copy link
Author

snyff commented Apr 30, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@AppVeyorBot
Copy link

Build brotli 1.0.0#1424 completed (commit 7501b3b590 by @snyff)

@eustas
Copy link
Collaborator

eustas commented May 2, 2019

Thanks for your contribution.

Unfortunately, it looks wrong to advice users to use 'sudo'. Some might get suspicious.
Usually, non-priviliged users already know that they have to set prefix to their user dir. Privileged users have "sudo" reflex for "make install" =)

@eustas eustas closed this May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants