Skip to content
This repository was archived by the owner on May 25, 2022. It is now read-only.

Conversation

@davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented Sep 11, 2016

This change is Reviewable

@manuelF
Copy link

manuelF commented Sep 11, 2016

:lgtm:


Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion.


example/lib/collections.g.dart, line 116 at r1 (raw file):

class _$CollectionsBuilder extends CollectionsBuilder {
  _$CollectionsBuilder() : super._();
  void replace(Collections other) {

Maybe not for this PR, but could we have a better error message here if other is null? Otherwise it will fail with a exception on the copy of the first element, instead of actually saying that other is null.


Comments from Reviewable

@davidmorgan
Copy link
Contributor Author

Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion.


example/lib/collections.g.dart, line 116 at r1 (raw file):

Previously, manuelF (Manuel Ferreria) wrote…

Maybe not for this PR, but could we have a better error message here if other is null? Otherwise it will fail with a exception on the copy of the first element, instead of actually saying that other is null.

Thanks, will add that as a FR for built_value.

Comments from Reviewable

@davidmorgan davidmorgan merged commit 37c5781 into google:master Sep 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants