add advertise and scan options to the bench app #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardissuperman
approved these changes
May 28, 2025
| # pylint: disable=line-too-long | ||
|
|
||
| DEVICE_MIN_SCAN_INTERVAL = 25 | ||
| DEVICE_MIN_SCAN_INTERVAL = 2.5 |
Collaborator
There was a problem hiding this comment.
nit: does this mean changing min scan interval to 2.5 milli seconds?
Collaborator
Author
There was a problem hiding this comment.
This change corrects a mistake where this constant was set at 25ms instead of 2.5ms. According to the spec, the scan interval value, in units of 0.625ms is allowed values in the range 0x0004 to 0x4000, so 2.5ms to 10.24s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows experimenting with the behavior of the controller when sending/receiving data while a scan and/or advertising is still going on.