Migrate L2CAP packets to dataclasses #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxzxwu
force-pushed
the
l2cap
branch
2 times, most recently
from
09475d9 to
3dd79b6
Compare
zxzxwu
changed the title
zxzxwu
force-pushed
the
l2cap
branch
2 times, most recently
from
ce8323b to
d21b9c5
Compare
zxzxwu
changed the title
barbibulle
approved these changes
Jul 19, 2025
bumble/l2cap.py
Outdated
| fields: ClassVar[hci.Fields] = () | ||
| code: int = dataclasses.field(default=0, init=False) | ||
| name: str = dataclasses.field(default='', init=False) | ||
| _parameters: Optional[bytes] = dataclasses.field(default=None, init=False) |
Collaborator
There was a problem hiding this comment.
This should be called data rather than parameters, as per the spec (parameters is really a command/event concept).
Collaborator
Author
There was a problem hiding this comment.
Done, renamed parameters -> data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.