Skip to content

Conversation

@khsiao-google
Copy link
Collaborator

Handle the following HCI commands / events and make device API for them

  1. HCI_LE_Subrate_Change
  2. HCI_LE_Set_Default_Subrate
  3. HCI_LE_Subrate_Request

@khsiao-google khsiao-google requested a review from zxzxwu August 3, 2025 03:41
@khsiao-google khsiao-google requested a review from zxzxwu August 5, 2025 05:57
@zxzxwu zxzxwu requested a review from barbibulle August 5, 2025 08:14
@barbibulle
Copy link
Collaborator

The way I understand the spec, I think that when there's a LE Connection Update Complete event, if the subrate factor and continuation number are only reset if there's a change in the connection interval. So if there's no change, the Connection.Parameters object that's created in the on_connection_parameters_update method should reuse the existing values for subrate_factor and continuation_number.

@khsiao-google
Copy link
Collaborator Author

The way I understand the spec, I think that when there's a LE Connection Update Complete event, if the subrate factor and continuation number are only reset if there's a change in the connection interval. So if there's no change, the Connection.Parameters object that's created in the on_connection_parameters_update method should reuse the existing values for subrate_factor and continuation_number.

I think that's a great point. Already modify the on_connection_parameters_update so that it only resets when connection interval changes.

@zxzxwu zxzxwu merged commit a275c39 into google:main Aug 7, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants