Add typing for host.py #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khsiao-google
force-pushed
the
update
branch
2 times, most recently
from
359f3e5 to
539b8d4
Compare
zxzxwu
reviewed
Sep 1, 2025
bumble/host.py
Outdated
| self.bigs[event.big_handle] = set(event.connection_handle) | ||
| if self.iso_packet_queue is None: | ||
| logger.warning("BIS established but ISO packets not supported") | ||
| raise ValueError("BIG established but ISO packets not supported") |
Collaborator
There was a problem hiding this comment.
Avoid using primitive errors. Use errors defined in bumble.core instead.
Collaborator
Author
There was a problem hiding this comment.
Is InvalidPacketError suitable for this scenario?
Collaborator
There was a problem hiding this comment.
InvalidStateError should be proper.
khsiao-google
force-pushed
the
update
branch
from
539b8d4 to
adfadb1
Compare
khsiao-google
force-pushed
the
update
branch
2 times, most recently
from
eaf5a87 to
60ad7fd
Compare
khsiao-google
force-pushed
the
update
branch
from
60ad7fd to
c720ad5
Compare
zxzxwu
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.