Improve support for Cabbie's event IDs.#108
Merged
copybara-service[bot] merged 1 commit intomasterfrom Aug 4, 2022
Merged
Conversation
copybara-service
bot
force-pushed
the
test_465099179
branch
2 times, most recently
from
d27fe6f to
004a908
Compare
The event library being used registers the EventMessageFile in the event source as C:\Program Files\Google\Cabbie\events.dll. This doesn't support some of the higher event IDs used by recent Cabbie updates. The events.mc file can be used to generate a resource DLL which, if bundled with Cabbie, can replace the EventMessageFile and should allow event messages to display correctly. PiperOrigin-RevId: 465336946
copybara-service
bot
force-pushed
the
test_465099179
branch
from
004a908 to
234f2ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve support for Cabbie's event IDs.
The event library being used registers the EventMessageFile in the event source as C:\Program Files\Google\Cabbie\events.dll. This doesn't support some of the higher event IDs used by recent Cabbie updates.
The events.mc file can be used to generate a resource DLL which, if bundled with Cabbie, can replace the EventMessageFile and should allow event messages to display correctly.