Automated Github releases with Github Actions! #46
Automated Github releases with Github Actions! #46discentem wants to merge 25 commits intogoogle:masterfrom discentem:master
Conversation
Builds and releases
|
I've just realized something, which may be tricky to figure out: we probably should not build a release if only Please let me know if I should exclude the readme or any other files. |
Old: ``` PS C:\Users\brandon_kurtz> C:\Users\brandon_kurtz\Downloads\cabbie.exe install Host has existing updates pending reboot. No reboot needed. ``` New: ``` PS C:\Windows\system32> C:\Users\brandon_kurtz\Desktop\cabbie-upstream.exe install Host has existing updates pending reboot. Please reboot to finalize the update installation. ```
This reverts commit 102aea6.
Old: Host has existing updates pending reboot. No reboot needed. New: Host has existing updates pending reboot. Please reboot to finalize the update installation.
fix wonky reboot messaging
|
Just wondering - has https://goreleaser.com been considered? Seems like goreleaser would accomplish what you're trying to do in this PR, in a potentially simpler fashion. |
|
TIL about https://goreleaser.com. I looked over the goreleaser docs quickly but I'm not sure if I'll be able to work on a goreleaser version of this any time soon. If you'd prefer to the goreleaser direction, feel free to close this though. |
…utput when new releases are created - This is meant to address #46 by @discentem - See https://github.com/TsekNet/cabbie/releases/tag/v1.0.3 for an example. PiperOrigin-RevId: 418932715
…utput when new releases are created - This is meant to address #46 by @discentem - See https://github.com/TsekNet/cabbie/releases/tag/v1.0.3 for an example. PiperOrigin-RevId: 418932715
…utput when new releases are created - This is meant to address #46 by @discentem - See https://github.com/TsekNet/cabbie/releases/tag/v1.0.3 for an example. PiperOrigin-RevId: 418953377
|
FYI @discentem - Cabbie can now be downloaded via releases |
2 participants
Apologies for the multiple false starts! I was doing a bunch of testing on my fork and a few times I accidentally PRed against google/cabbie instead of discentem/cabbie.
So what does this PR actually do?
build_pr.ymlcabbie.exeon every push tomasterinbuild_release.yml. Note: every change is considered a minor release based on theminor_patternregex I wrote. I figured this was the best way to automatically version. See https://github.com/discentem/cabbie/blob/master/.github/workflows/build_release.yml#L32 and https://github.com/PaulHatch/semantic-version#usage for more context. There are many ways the automatic versioning could work and I'm happy to make changes as desired.cabbie.exeif any tag is manually created. I figured this is useful if you want to manually release with a manually created version number.Please let know if you have feedback or questions! Thanks!