Skip to content

Comments

statsd docs (Issue #2002)#2005

Merged
dashpole merged 3 commits intogoogle:masterfrom
salaxander:statsd_docs
Jul 27, 2018
Merged

statsd docs (Issue #2002)#2005
dashpole merged 3 commits intogoogle:masterfrom
salaxander:statsd_docs

Conversation

@salaxander
Copy link

This is the start of documentation for statsd (issue #2002). Happy to add more detail if needed, but this should be enough to get people off the ground with it :)

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@dashpole
Copy link
Collaborator

/ok-to-test

@salaxander
Copy link
Author

salaxander commented Jul 19, 2018

Signed the CLA! :)

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@salaxander
Copy link
Author

Comment for another CLA check!

@dashpole
Copy link
Collaborator

make sure you follow this: https://help.github.com/articles/setting-your-commit-email-address-on-github/. From the fact that I dont see your icon on the commits above, this is probably what you are missing

@salaxander
Copy link
Author

Comment for another CLA check!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@salaxander
Copy link
Author

@dashpole - Thanks for the guidance on that! Turns out I was missing an alternate email on my Google and GitHub account

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit a390d2e into google:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants