Report error while fetching network stats. #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @vishh |
container/libcontainer/helpers.go
Outdated
There was a problem hiding this comment.
Why not return immediately if there is an error?
There was a problem hiding this comment.
Only reason is to provide partial stats if they're available (i.e.: only CPU and memory)
There was a problem hiding this comment.
Hmm. That would complicate the API. If we intend to ignore network errors, why not just log it instead of propagating it?
|
Done, PTAL. |
container/docker/factory.go
Outdated
There was a problem hiding this comment.
Two arguments passed, but only is expected.
|
@vmarmol: Just a few more comments. |
|
Ooops, committed more than I meant to. Fixed, PTAL. |
vishh
added a commit
that referenced
this pull request
Dec 10, 2014
Report error while fetching network stats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.