Added container event monitoring#539
Merged
Merged
Conversation
|
Can one of the admins verify this patch? |
Contributor
Author
|
This will allow container events (creation and deletion) to be tracked by the manager's event manager. |
Contributor
|
ok to test |
Contributor
There was a problem hiding this comment.
remove log line since we are returning the error
kateknister
force-pushed
the
apiBranch
branch
4 times, most recently
from
dee0ad8 to
7993b24
Compare
|
Can one of the admins verify this patch? |
kateknister
force-pushed
the
apiBranch
branch
from
7993b24 to
5b0bced
Compare
Contributor
|
ok to test |
Contributor
There was a problem hiding this comment.
We probably don't want to return our internal container data structure here :) How about we return ContainerSpec instead since that is a user-facing structure.
Contributor
There was a problem hiding this comment.
Actually, can we move this to New?
kateknister
force-pushed
the
apiBranch
branch
3 times, most recently
from
fb37328 to
d90b9ca
Compare
Contributor
|
LGTM thanks @kateknister :) |
vmarmol
added a commit
that referenced
this pull request
Mar 4, 2015
Added container event monitoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.