Make machine-id sources flag a comma-separated list.#561
Merged
Conversation
Contributor
There was a problem hiding this comment.
nit: Why not report an error instead of info?
Contributor
Author
There was a problem hiding this comment.
I am not sure if we have machine-id on all distro. It might be expected to fail on some hosts.
Contributor
|
LGTM. The e2e tests are failing on CoreOS. |
Contributor
|
LGTM |
Use "/etc/machine-id,/var/lib/dbus/machine-id" as default.
Contributor
Author
|
e2e test seems to be flaky. Running it again fixed it. |
Contributor
|
Grrr need to tackle the flakes. LGTM |
vmarmol
added a commit
that referenced
this pull request
Mar 5, 2015
Make machine-id sources flag a comma-separated list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use "/etc/machine-id,/var/lib/dbus/machine-id" as default.