Bump astro from 5.14.1 to 5.14.4 in /site in the npm_and_yarn group across 1 directory#1
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps the npm_and_yarn group with 1 update in the /site directory: [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro). Updates `astro` from 5.14.1 to 5.14.4 - [Release notes](https://github.com/withastro/astro/releases) - [Changelog](https://github.com/withastro/astro/blob/main/packages/astro/CHANGELOG.md) - [Commits](https://github.com/withastro/astro/commits/astro@5.14.4/packages/astro) --- updated-dependencies: - dependency-name: astro dependency-version: 5.14.4 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
Author
|
Superseded by #3. |
ebursztein
added a commit
that referenced
this pull request
Apr 20, 2026
Two independent but colocated bugs in crates/capsem-app/src/main.rs. 1. blocking_show() in async context. check_for_update_with_prompt is an async fn spawned on the tauri/ tokio runtime, and it called tauri_plugin_dialog's .blocking_show() at line 108. The user can leave the dialog sitting for seconds or minutes, so a runtime worker was held for human time -- same anti-pattern as std::process::Command in async (tray fix, bug #1). spawn_blocking is NOT the fix here: its bounded pool is for short blocking I/O, not human-time waits. The idiomatic path is the plugin's callback-based .show(|accepted| ...) bridged to the async call site via tokio::sync::oneshot. Same shape, zero threads held. 2. World-readable session logs. ~/.capsem/logs/<ts>.jsonl was opened via std::fs::File::create, which respects the process umask (typically 0644) and makes the file readable by every local user. The log stream includes tracing spans with VM ids, filesystem paths, provider API metadata, and tool-call arguments. Factored an open_log_file(path) that uses OpenOptions::mode(0o600) under cfg(unix) with a plain fallback, matching pty_log.rs, the gateway auth token, per-VM sockets, and capsem-core's key helpers (dev-rust-patterns lesson 14). TDD: 2 new tests in capsem-app - open_log_file_creates_file_and_returns_writable_handle - open_log_file_restricts_permissions_to_0600 (cfg(unix)) Stated up front: the dialog bug is not unit-testable without a live Tauri app harness, so the fix ships on visual diff + green existing suite + clippy -D warnings. All 14 capsem-app tests pass. Clippy: cleared a pre-existing needless_borrows_for_generic_args on the deep-link window.eval call in the same file to keep the gate green per the no-pre-existing-dismissal rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the npm_and_yarn group with 1 update in the /site directory: astro.
Updates
astrofrom 5.14.1 to 5.14.4Release notes
Sourced from astro's releases.
Changelog
Sourced from astro's changelog.
... (truncated)
Commits
3412859[ci] release (#14510)7e04cafdocs: fixsecurity.allowedDomainsversion (#14509)fe1d35c[ci] release (#14507)7926882[ci] formatc4d84bbfix(prefetch): Fix "tap" prefetch strategy when view transitions are enabled ...3bb14b7[ci] release (#14466)7a5aaff[ci] format28b2a1dFix failing x-forwarded-host tests (#14505)ec307b0[ci] format6ee63bfMerge commit from forkDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.