Fix cctz::format()/parse() to treat NULs like any other chars#338
Merged
derekmauro merged 1 commit intogoogle:masterfrom Mar 2, 2026
Merged
Fix cctz::format()/parse() to treat NULs like any other chars#338derekmauro merged 1 commit intogoogle:masterfrom
derekmauro merged 1 commit intogoogle:masterfrom
Conversation
The previous commit (PR google#337) was couched in terms of `parse()` rejecting input strings containing NULs. Instead, we should treat NULs like other characters by allowing them in both the format and input strings. Similarly, `format()` should allow NULs in its format string. Also: - Simplify `FormatTM()` calls by handling an empty format string internally, rather than by guarding each invocation. - Utilize the `std::string` iterator-pair constructor and `append()`.
derekmauro
approved these changes
Mar 2, 2026
Member
derekmauro
left a comment
derekmauro
left a comment
There was a problem hiding this comment.
Thank you. This is a more technically principled approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous commit (PR #337) was couched in terms of
parse()rejecting input strings containing NULs. Instead, we should treat NULs like other characters by allowing them in both the format and input strings.Similarly,
format()should allow NULs in its format string.Also:
FormatTM()calls by handling an empty format string internally, rather than by guarding each invocation.std::stringiterator-pair constructor andappend().