Make error handling in wrapped legacy map consistent with modern version.#1948
Merged
copybara-service[bot] merged 1 commit intomasterfrom Apr 20, 2026
Merged
Make error handling in wrapped legacy map consistent with modern version.#1948copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test_900900524
branch
2 times, most recently
from
be9a474 to
4efe017
Compare
…ion. The wrapped legacy implementation would use absl status return to propagate expected errors leading to inconsistencies in error handling depending on whether the underlying map was backed by a modern or legacy map. Update so that expected errors are cel::ErrorValue and unexpected errors (internal bug or client error) are returned as non-ok Status return value. Add Documentation for MapValue members. PiperOrigin-RevId: 902798507
copybara-service
bot
force-pushed
the
test_900900524
branch
from
4efe017 to
c1e3026
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make error handling in wrapped legacy map consistent with modern version.
The wrapped legacy implementation would use absl status return to propagate expected errors leading to inconsistencies in
error handling depending on whether the underlying map was backed by a modern or legacy map. Update so that expected errors
are cel::ErrorValue and unexpected errors (internal bug or client error) are returned as non-ok Status return value.
Add Documentation for MapValue members.