Skip to content

Remove base/memory.h #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Feb 5, 2024
Merged

Remove base/memory.h #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions base/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,6 @@ cc_library(
],
)

cc_library(
name = "memory",
hdrs = [
"memory.h",
],
deps = [
"//common:memory",
"@com_google_absl//absl/base:core_headers",
],
)

cc_library(
name = "operators",
srcs = ["operators.cc"],
Expand Down Expand Up @@ -203,7 +192,7 @@ cc_test(
":function_adapter",
":function_descriptor",
":kind",
":memory",
"//common:memory",
"//common:value",
"//internal:testing",
"@com_google_absl//absl/status",
Expand Down
2 changes: 1 addition & 1 deletion base/function_adapter_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@
#include "base/function.h"
#include "base/function_descriptor.h"
#include "base/kind.h"
#include "base/memory.h"
#include "base/type_factory.h"
#include "base/type_manager.h"
#include "base/type_provider.h"
#include "base/value.h"
#include "base/value_factory.h"
#include "common/memory.h"
#include "common/value.h"
#include "common/values/legacy_type_reflector.h"
#include "common/values/legacy_value_manager.h"
Expand Down
2 changes: 1 addition & 1 deletion base/internal/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ cc_test(
":function_adapter",
"//base:data",
"//base:kind",
"//base:memory",
"//common:memory",
"//common:value",
"//internal:testing",
"@com_google_absl//absl/status",
Expand Down
2 changes: 1 addition & 1 deletion base/internal/function_adapter_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@
#include "absl/status/statusor.h"
#include "absl/time/time.h"
#include "base/kind.h"
#include "base/memory.h"
#include "base/type_factory.h"
#include "base/type_manager.h"
#include "base/type_provider.h"
#include "base/value.h"
#include "base/value_factory.h"
#include "common/memory.h"
#include "common/value.h"
#include "common/values/legacy_type_reflector.h"
#include "common/values/legacy_value_manager.h"
Expand Down
145 changes: 0 additions & 145 deletions base/memory.h
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion conformance/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ cc_binary(
deps = [
"//base:data",
"//base:kind",
"//base:memory",
"//common:any",
"//common:memory",
"//eval/public:activation",
"//eval/public:builtin_func_registrar",
"//eval/public:cel_expr_builder_factory",
Expand Down
14 changes: 7 additions & 7 deletions eval/compiler/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ cc_library(
"//base:ast",
"//base:builtins",
"//base:data",
"//base:memory",
"//base/ast_internal:ast_impl",
"//base/ast_internal:expr",
"//common:memory",
"//common:value",
"//eval/eval:comprehension_step",
"//eval/eval:const_value_step",
Expand Down Expand Up @@ -258,9 +258,9 @@ cc_library(
"//base:builtins",
"//base:data",
"//base:kind",
"//base:memory",
"//base/ast_internal:ast_impl",
"//base/ast_internal:expr",
"//common:memory",
"//common:value",
"//eval/eval:const_value_step",
"//eval/eval:evaluator_core",
Expand All @@ -284,9 +284,9 @@ cc_test(
":resolver",
"//base:ast",
"//base:data",
"//base:memory",
"//base/ast_internal:ast_impl",
"//base/ast_internal:expr",
"//common:memory",
"//common:value",
"//eval/eval:const_value_step",
"//eval/eval:create_list_step",
Expand Down Expand Up @@ -346,7 +346,7 @@ cc_library(
deps = [
"//base:data",
"//base:kind",
"//base:memory",
"//common:memory",
"//common:type",
"//internal:status_macros",
"//runtime:function_overload_reference",
Expand All @@ -371,9 +371,9 @@ cc_test(
"//base:ast",
"//base:builtins",
"//base:data",
"//base:memory",
"//base/ast_internal:ast_impl",
"//base/ast_internal:expr",
"//common:memory",
"//common:value",
"//eval/public:builtin_func_registrar",
"//eval/public:cel_function",
Expand Down Expand Up @@ -424,7 +424,7 @@ cc_test(
deps = [
":resolver",
"//base:data",
"//base:memory",
"//common:memory",
"//common:value",
"//eval/public:cel_function",
"//eval/public:cel_function_registry",
Expand Down Expand Up @@ -471,9 +471,9 @@ cc_test(
":flat_expr_builder_extensions",
":regex_precompilation_optimization",
"//base:data",
"//base:memory",
"//base/ast_internal:ast_impl",
"//base/ast_internal:expr",
"//common:memory",
"//common:value",
"//eval/eval:cel_expression_flat_impl",
"//eval/eval:evaluator_core",
Expand Down
2 changes: 1 addition & 1 deletion eval/compiler/constant_folding.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef THIRD_PARTY_CEL_CPP_EVAL_COMPILER_CONSTANT_FOLDING_H_
#define THIRD_PARTY_CEL_CPP_EVAL_COMPILER_CONSTANT_FOLDING_H_

#include "base/memory.h"
#include "common/memory.h"
#include "eval/compiler/flat_expr_builder_extensions.h"

namespace cel::runtime_internal {
Expand Down
2 changes: 1 addition & 1 deletion eval/compiler/constant_folding_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
#include "base/ast.h"
#include "base/ast_internal/ast_impl.h"
#include "base/ast_internal/expr.h"
#include "base/memory.h"
#include "base/type_factory.h"
#include "base/type_manager.h"
#include "base/value_manager.h"
#include "common/memory.h"
#include "common/value.h"
#include "common/values/legacy_value_manager.h"
#include "eval/compiler/flat_expr_builder_extensions.h"
Expand Down
2 changes: 1 addition & 1 deletion eval/compiler/flat_expr_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@
#include "base/ast_internal/ast_impl.h"
#include "base/ast_internal/expr.h"
#include "base/builtins.h"
#include "base/memory.h"
#include "base/type_factory.h"
#include "base/type_provider.h"
#include "base/value_manager.h"
#include "common/memory.h"
#include "common/values/legacy_value_manager.h"
#include "eval/compiler/flat_expr_builder_extensions.h"
#include "eval/compiler/resolver.h"
Expand Down
2 changes: 1 addition & 1 deletion eval/compiler/qualified_reference_resolver_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@
#include "base/ast_internal/ast_impl.h"
#include "base/ast_internal/expr.h"
#include "base/builtins.h"
#include "base/memory.h"
#include "base/type_factory.h"
#include "base/type_manager.h"
#include "base/value_manager.h"
#include "common/memory.h"
#include "common/values/legacy_value_manager.h"
#include "eval/compiler/resolver.h"
#include "eval/public/builtin_func_registrar.h"
Expand Down
2 changes: 1 addition & 1 deletion eval/compiler/regex_precompilation_optimization_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
#include "google/api/expr/v1alpha1/syntax.pb.h"
#include "base/ast_internal/ast_impl.h"
#include "base/ast_internal/expr.h"
#include "base/memory.h"
#include "base/type_factory.h"
#include "base/type_manager.h"
#include "base/value_manager.h"
#include "common/memory.h"
#include "common/values/legacy_value_manager.h"
#include "eval/compiler/cel_expression_builder_flat_impl.h"
#include "eval/compiler/constant_folding.h"
Expand Down
2 changes: 1 addition & 1 deletion eval/compiler/resolver.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@
#include "absl/strings/strip.h"
#include "absl/types/optional.h"
#include "base/kind.h"
#include "base/memory.h"
#include "base/value.h"
#include "base/value_manager.h"
#include "common/memory.h"
#include "common/type.h"
#include "internal/status_macros.h"
#include "runtime/function_overload_reference.h"
Expand Down
2 changes: 1 addition & 1 deletion eval/compiler/resolver_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@

#include "absl/status/status.h"
#include "absl/types/optional.h"
#include "base/memory.h"
#include "base/type_factory.h"
#include "base/type_manager.h"
#include "base/type_provider.h"
#include "base/value_manager.h"
#include "common/memory.h"
#include "common/value.h"
#include "common/values/legacy_value_manager.h"
#include "eval/public/cel_function.h"
Expand Down
Loading