Expose Match source ID to callers. #1227
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristonianJones
previously approved these changes
Nov 10, 2025
Collaborator
|
/gcbrun |
catalinadurbala
force-pushed
the
structured-explanations
branch
from
dc78c17 to
f43ab48
Compare
Contributor
Author
|
Sorry, I accidentally added another commit that should've gone to a different PR. I've now removed it from this PR but it looks like it invalidated the check anyway :( |
Collaborator
|
/gcbrun |
2 similar comments
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
TristonianJones
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the exprID of Matches accessible to callers.
Will be used as keys for additional per-Match metadata, with the end
goal of compiling an AST where the output is comprised of this metadata
instead.