fix: deleted IntToDuration overload#1300
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
4 tasks
Contributor
Author
It's not, changed the email to the one you have on file for the CLA. |
Collaborator
|
/gcbrun |
TristonianJones
previously approved these changes
Apr 8, 2026
Collaborator
|
@alexsnaps could you update testdata/standard_env.prompt.txt and remove line 222: cel-go/cel/testdata/standard_env.prompt.txt Line 222 in 6b8f6d6 |
Contributor
Author
|
Fixed |
Collaborator
|
/gcbrun |
Contributor
Author
|
If I get this failure right, it complains about the line being gone now? Is that right? I really have no where the "authority" for that is sourced from... I have no experience with this test suite tbh |
Collaborator
|
@alexsnaps it looks like there's one more file where the line |
The conversion isn't implemented, but mostly isn't part of the language specification. The behavior remains mostly unchanged, the resulting error changes tho, still an error: - pre: type conversion error from 'int' to 'google.protobuf.Duration' - post: found no matching overload for 'duration' applied to '(int)' Signed-off-by: Alex Snaps <asnaps@redhat.com>
Contributor
Author
|
🤞 |
Collaborator
|
/gcbrun |
TristonianJones
approved these changes
Apr 14, 2026
Maks1mS
pushed a commit
to stplr-dev/stplr
that referenced
this pull request
May 13, 2026
This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [github.com/google/cel-go](https://github.com/google/cel-go) | require | patch | `v0.28.0` → `v0.28.1` | [](https://securityscorecards.dev/viewer/?uri=github.com/google/cel-go) | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/23) for more information. --- ### Release Notes <details> <summary>google/cel-go (github.com/google/cel-go)</summary> ### [`v0.28.1`](https://github.com/google/cel-go/releases/tag/v0.28.1) [Compare Source](google/cel-go@v0.28.0...v0.28.1) #### What's Changed - fix: deleted `IntToDuration` overload by [@​alexsnaps](https://github.com/alexsnaps) in [#​1300](google/cel-go#1300) - Support shorthand types in env yaml and REPL by [@​jnthntatum](https://github.com/jnthntatum) in [#​1301](google/cel-go#1301) - Preserve operation interrupted in ContextEval error by [@​dims](https://github.com/dims) in [#​1303](google/cel-go#1303) - Use shorthand type specifiers in env yaml files by [@​jnthntatum](https://github.com/jnthntatum) in [#​1305](google/cel-go#1305) - Cost estimation and tracking for strings extension by [@​TristonianJones](https://github.com/TristonianJones) in [#​1307](google/cel-go#1307) - Update repl type string for doubles by [@​TristonianJones](https://github.com/TristonianJones) in [#​1308](google/cel-go#1308) #### New Contributors - [@​alexsnaps](https://github.com/alexsnaps) made their first contribution in [#​1300](google/cel-go#1300) - [@​dims](https://github.com/dims) made their first contribution in [#​1303](google/cel-go#1303) **Full Changelog**: <google/cel-go@v0.28.0...v0.28.1> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At 12:00 AM through 04:59 AM and 10:00 PM through 11:59 PM, Monday through Friday (`* 0-4,22-23 * * 1-5`) - Only on Sunday and Saturday (`* * * * 0,6`) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNzAuMjIiLCJ1cGRhdGVkSW5WZXIiOiI0My4xNzAuMjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIktpbmQvRGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://altlinux.space/stapler/stplr/pulls/431
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversion isn't implemented, but mostly isn't part of the language specification. The behavior remains mostly unchanged, the resulting error changes tho, still an error:
The error would now be caught by the checker, instead of the evaluation time one previously.