New warnings with svg externs

[vobruba-martin]

After this commit c3ab4a2

externs.zip//svg.js:3704: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFECompositeElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:3746: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGDescElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:3895: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGEllipseElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:3978: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFESpecularLightingElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:4125: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFEColorMatrixElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:4187: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGSymbolElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:4374: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFEConvolveMatrixElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:4433: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFEFloodElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:4468: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGStopElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:4577: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFEOffsetElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:4677: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFilterElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:4774: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFEGaussianBlurElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:4966: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGTitleElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:5144: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGGradientElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:5343: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGMarkerElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:5443: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGMaskElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:5648: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFEImageElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:5777: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFEDiffuseLightingElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:5910: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFEMorphologyElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:5982: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGGlyphRefElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:6163: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGTextContentElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:6362: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFEDropShadowElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:6427: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFETileElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:6596: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFEBlendElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:6734: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGPatternElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:7226: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGSVGElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:7364: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGDefsElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:7500: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGPolygonElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:7846: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGPathElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:7988: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGCircleElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:8155: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGUseElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:8291: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGPolylineElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:8415: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGGElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:8539: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGSwitchElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:8700: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGImageElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:8860: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGRectElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:8997: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGAElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:9247: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFETurbulenceElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:9491: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGClipPathElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:9989: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGLineElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:10054: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFEComponentTransferElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:10213: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFEDisplacementMapElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:10291: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGFEMergeElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

externs.zip//svg.js:10439: WARNING - Invalid redeclaration of property style.
inherited type  : CSSStyleDeclaration
overriding type : Array<string>|CSSStyleDeclaration

SVGForeignObjectElement.prototype.style;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[MatrixFrog]

It looks like those are coming from NTI? cc @dimvar

[dimvar]

These look correct. The property style is redefined on the subtypes of Element and includes Array<string>, which is not a subtype of CSSStyleDeclaration.

[vobruba-martin]

Yes, it is from NTI. Does it mean that svg.js in externs is incorrectly defined?

[dimvar]

Yes, and it looks like the old type checker does not catch this warning.

Anyway, this warning is working as intended, so I'm closing this issue.

[vobruba-martin]

Warnings are working as intended but shouldn't be svg.js corrected before closing this issue?

[dimvar]

Yes, you're right.

@MatrixFrog is the file being used at Google, or can we just revert the PR if necessary?

[MatrixFrog]

It's probably being used at Google but we can remove it from the open-source repo if the warnings are bothering people. Or maybe we can just remove it from the set of default externs, since most apps don't use svg anyway. Or maybe someone will volunteer to just fix the warnings.

[freshp86]

FWIW, when I proposed (and landed) c3ab4a2, I thought that the externs would simply be available in this repo, but they would not be automatically included in the default set of externs.