Fix glob on Windows and fix regression

[Dominator008]

Fixes #1407.
Fixes #1477.

[ChadKillingsworth]

I can test this tonight, but I don't have a windows build environment at the office.

[Dominator008]

@ChadKillingsworth This is passing on my Windows environment.

[ChadKillingsworth]

Yeah I just meant if we wanted someone else to try it out - since Travis can't build on Windows.

[Dominator008]

@supersteves Can you help verifying this? Thanks!

[ChadKillingsworth]

@Dominator008 Did you see the comment by @joeltine on #1407? Does that pattern work with this change?

[Dominator008]

@ChadKillingsworth No it doesn't seem to be working :(

[Dominator008]

@ChadKillingsworth OK the regression should be fixed now.

[supersteves]

Fix verified 👍
(strange how Ant failed but Mvn hung, though - but both working now)

[Dominator008]

Thanks @supersteves !

[dimvar]

@Dominator008 can you add a unit test for the --js='!**\./node_modules**.js' pattern?

[dimvar]

Other than that lgtm

[Dominator008]

@dimvar The unit test for --js='!**\./foo**.js' requires creating a temporary directory under the current working directory (see testGlobJs5). This works on my machine, but I'm not sure if it will work internally since we need to have write permission on the current working directory.

[dimvar]

OK sounds good. LGTM then. I'll look to see if I can add a unit test internally after this lands. I'll merge this once Travis is done.

[dimvar]

@Dominator008 looks like the travis build failed. Can you look into it so we can merge the PR?

[Dominator008]

@dimvar The Travis build failed for other reasons and I fixed them in #1486. I've rebased this on top of master. Let's see if this one succeeds :)

[dimvar]

Thanks! Feel free to merge this once Travis is done.