Add pom-linter.xml to build closure-compiler-linter.jar with Maven #1650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dominator008
force-pushed
the
maven-linter
branch
from
803df0a to
77c0aae
Compare
| what's left. It also checks syntax, variable references, and types, and | ||
| warns about common JavaScript pitfalls. It is used in many of Google's | ||
| JavaScript apps, including Gmail, Google Web Search, Google Maps, and | ||
| Google Docs. |
There was a problem hiding this comment.
Since this POM file is for the linter specifically maybe we should add another sentence about the linter. "This binary checks for style issues such as incorrect or missing JSDoc usage, and missing goog.require() statements. It does not do more advanced checks such as typechecking." or something like that
Dominator008
force-pushed
the
maven-linter
branch
from
77c0aae to
1408977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is