Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

Conversation

@gberaudo
Copy link
Contributor

ERR! compile closure/goog/fx/dragger.js:231: ERROR - unnecessary cast
ERR! compile from: Element
ERR! compile to : (Element|null)
ERR! compile var clonedEl = /** @type {Element} */ (sourceEl.cloneNode(true)),

gberaudo added a commit to gberaudo/openlayers that referenced this pull request Jan 27, 2016
There is still such a cast in the goog library itself.
See google/closure-library#637
gberaudo added a commit to gberaudo/openlayers that referenced this pull request Jan 27, 2016
There is still such a cast in the goog library itself.
See google/closure-library#637
@gberaudo
Copy link
Contributor Author

Travis is unhappy due to some errors caused by the compiler.
With an older compiler version it passes at my place.

ERROR - Cannot read: !**\./node_modules**.js
...
12 error(s), 0 warning(s)
The command "./scripts/ci/compile_closure.sh" exited with 12.

@gberaudo
Copy link
Contributor Author

I bisected the closure compiler and found the first failing commit to be
62ca536d0a184a8852646e2bc2db178f700f5cfc Fix the bug that jscompiler does not respect relative order of --js to --zip inputs.

gberaudo added a commit to gberaudo/openlayers that referenced this pull request Jan 27, 2016
There is still such a cast in the goog library itself.
See google/closure-library#637
@Dominator008
Copy link
Contributor

@gberaudo This is a known bug google/closure-compiler#1407
I have a fix but it's not merged yet.

@gberaudo
Copy link
Contributor Author

Thanks @Dominator008. Looking forward for the merging of your fix.

@joeltine
Copy link
Contributor

The compiler fix was merged.

@gberaudo
Copy link
Contributor Author

Thanks @joeltine and @Dominator008.
I tested the pending PR google/closure-compiler#1469 and it fixes the build.

@Dominator008
Copy link
Contributor

@gberaudo Good to know. Thanks for testing it out!

@gberaudo
Copy link
Contributor Author

gberaudo commented Feb 1, 2016

@joeltine, @Dominator008, just restarted the build but it still fails on travis.
That is strange since on my machine, with the same version of the compiler, a call toscripts/ci/compile_closure.sh works fine. Any idea of what could be wrong?

@joeltine
Copy link
Contributor

joeltine commented Feb 1, 2016

Honestly, not a clue atm.

Were you able to repro the breakage on your machine at any point in the past?

@joeltine
Copy link
Contributor

joeltine commented Feb 1, 2016

Mmkay I figured it out. It was only the node_modules glob that was broken. I have a fix here: #642.

My guess is that you didn't have any node modules installed in your closure directory and that's why your build succeeded.

@joeltine
Copy link
Contributor

joeltine commented Feb 3, 2016

The latest travis failure is unrelated to this change. It was fixed in b21ef38.

Can you please rebase and kick off another Travis run? If it's good, I'll merge this.

@joeltine joeltine self-assigned this Feb 3, 2016
ERR! compile closure/goog/fx/dragger.js:231: ERROR - unnecessary cast
ERR! compile from: Element
ERR! compile to  : (Element|null)
ERR! compile   var clonedEl = /** @type {Element} */ (sourceEl.cloneNode(true)),
@gberaudo
Copy link
Contributor Author

gberaudo commented Feb 3, 2016

Travis is passing now, thanks @joeltine.

gberaudo added a commit to gberaudo/openlayers that referenced this pull request Feb 3, 2016
There is still such a cast in the goog library itself.
See google/closure-library#637
joeltine added a commit that referenced this pull request Feb 3, 2016
@joeltine joeltine merged commit d089b06 into google:master Feb 3, 2016
@gberaudo gberaudo deleted the remove_unnecessary_cast_fx_dragger branch February 4, 2016 07:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants