-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove unnecessary cast #637
Remove unnecessary cast #637
Conversation
There is still such a cast in the goog library itself. See google/closure-library#637
There is still such a cast in the goog library itself. See google/closure-library#637
|
Travis is unhappy due to some errors caused by the compiler. |
|
I bisected the closure compiler and found the first failing commit to be |
There is still such a cast in the goog library itself. See google/closure-library#637
|
@gberaudo This is a known bug google/closure-compiler#1407 |
|
Thanks @Dominator008. Looking forward for the merging of your fix. |
|
The compiler fix was merged. |
|
Thanks @joeltine and @Dominator008. |
|
@gberaudo Good to know. Thanks for testing it out! |
|
@joeltine, @Dominator008, just restarted the build but it still fails on travis. |
|
Honestly, not a clue atm. Were you able to repro the breakage on your machine at any point in the past? |
|
Mmkay I figured it out. It was only the node_modules glob that was broken. I have a fix here: #642. My guess is that you didn't have any node modules installed in your closure directory and that's why your build succeeded. |
|
The latest travis failure is unrelated to this change. It was fixed in b21ef38. Can you please rebase and kick off another Travis run? If it's good, I'll merge this. |
ERR! compile closure/goog/fx/dragger.js:231: ERROR - unnecessary cast ERR! compile from: Element ERR! compile to : (Element|null) ERR! compile var clonedEl = /** @type {Element} */ (sourceEl.cloneNode(true)),
|
Travis is passing now, thanks @joeltine. |
There is still such a cast in the goog library itself. See google/closure-library#637
ERR! compile closure/goog/fx/dragger.js:231: ERROR - unnecessary cast
ERR! compile from: Element
ERR! compile to : (Element|null)
ERR! compile var clonedEl = /** @type {Element} */ (sourceEl.cloneNode(true)),