roundup integer type to be a multiple of 8#884
Merged
alan-baker merged 2 commits intogoogle:mainfrom Jul 18, 2022
Merged
Conversation
Most vulkan drivers do not support integer type not being a multiple of 8. Make sure we always produce integer type with a size multiple of 8. This will fix a compilation issue with libclc lgamma and lgamma_r functions.
Collaborator
|
Do lgamma and lgamma_r pass CTS? What functional tests have you run? |
Collaborator
Author
|
Yes they do on Intel, AMD and ARM GPUs. I have not tested it with Nvidia. |
alan-baker
requested changes
Jul 15, 2022
alan-baker
approved these changes
Jul 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most vulkan drivers do not support integer type not being a multiple
of 8.
Make sure we always produce integer type with a size multiple of 8.
This will fix a compilation issue with libclc lgamma and lgamma_r
functions.