Make label text customizable#1056
Merged
Merged
Conversation
Order of label and label_type can be different in different issue trackers. So, make it completely customizable.
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
TBR simple fix. |
oliverchang
reviewed
Sep 28, 2019
| @@ -273,6 +273,10 @@ def label_type(self): | |||
| """Label type.""" | |||
| return 'label' # default | |||
Collaborator
There was a problem hiding this comment.
seems like label_type is no longer needed, so we can remove to keep things simple?
Collaborator
Author
There was a problem hiding this comment.
It is used in one place here -
We can remove it if we fix this case somehow, but i don't see this as a big deal since we have a better label_type for google issue tracker (hotlist vs hotlistid) for this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Order of label and label_type can be different in different
issue trackers. So, make it completely customizable.