Auto-shrink testcase group when too many variants are found.#1105
Merged
Conversation
Collaborator
Author
|
/gcbrun |
1 similar comment
Collaborator
Author
|
/gcbrun |
oliverchang
approved these changes
Oct 15, 2019
oliverchang
left a comment
oliverchang
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I wonder if another way to address this is to make the similarity algorithm a bit more aggressive in the case of crash types with user provided input like CHECKs.
Collaborator
Author
I fixed some signature in crash analyzer, but there are more crazy cases. |
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
take another look, although i wont check this in until next week. |
Collaborator
Author
|
@oliverchang - can you please take another look. |
Collaborator
|
LGTM. Sorry didn't realise you were waiting on another review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a crash results in similar looking stacktraces that only differ in slight strings (e.g. numbers in check failure asserts), this can explode the number of testcases in a group, breaking crash management and processing. Since this happens from time to time, make it automatic to auto-shrink those testcase groups.