Prevent radamsa in process strategy if mutator plugin is already being used. #1398
Merged
Conversation
Contributor
Author
|
/gcbrun |
mbarbella-chromium
approved these changes
Jan 31, 2020
| if (strategy_pool.do_strategy(strategy.MUTATOR_PLUGIN_RADAMSA_STRATEGY) and | ||
| use_radamsa_mutator_plugin(extra_env)): | ||
| use_radamsa_mutator_plugin(extra_env) | ||
| ) and not fuzzing_strategies.contains( |
Contributor
There was a problem hiding this comment.
Nit: keep this close paren before the colon.
Contributor
Author
|
/gcbrun |
1 similar comment
Contributor
|
/gcbrun |
Dor1s
suggested changes
Jan 31, 2020
| if (strategy_pool.do_strategy(strategy.MUTATOR_PLUGIN_RADAMSA_STRATEGY) and | ||
| use_radamsa_mutator_plugin(extra_env)): | ||
| use_radamsa_mutator_plugin(extra_env) and | ||
| not fuzzing_strategies.contains(strategy.MUTATOR_PLUGIN_STRATEGY.name)): |
Contributor
There was a problem hiding this comment.
I think the order here is wrong. If line 1706 is true, then line 1707 gets executed and enables the plugin (as it sets the LD_PRELOAD and also logs the message), but then we can end with the false on line 1708, i.e. the strategy will be used but the stats will say it isn't.
Swap these two lines, and maybe add a comment on line 1706 explaining why one strategy needs the other one to be disabled
Contributor
Author
There was a problem hiding this comment.
This is a good catch! Thank you.
Contributor
Author
|
/gcbrun |
Dor1s
approved these changes
Jan 31, 2020
Contributor
Author
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.