Replace download_as_string with download_as_bytes #3291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bucket = client.bucket(bucket_name) | ||
| blob = bucket.blob(path, chunk_size=self._chunk_size()) | ||
| return blob.download_as_string() | ||
| return blob.download_as_bytes() |
Collaborator
There was a problem hiding this comment.
Does decode need to be called on this result to return the same type?
jonathanmetzman
force-pushed
the
master
branch
from
6faadb9 to
038efda
Compare
jonathanmetzman
force-pushed
the
master
branch
2 times, most recently
from
e7e91a0 to
22e1108
Compare
Collaborator
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #3257 by replacing ALLLLLLLLLLLLLLLLLL the download_as_string with download_as_bytes as it's Deprecated.