Add logging to debug windows libfuzzer backup failures.#383
Merged
Conversation
Collaborator
Author
|
gs://clusterfuzz-windows-corpus/libfuzzer// is all 22 bytes and empty. |
Collaborator
Author
|
/gcbrun |
Collaborator
|
Thanks! |
jonathanmetzman
approved these changes
Apr 12, 2019
| try: | ||
| backup_archive_path = shutil.make_archive(backup_archive_path, | ||
| BACKUP_ARCHIVE_FORMAT, directory) | ||
| logs.log('Created corpus backup file.', |
Collaborator
There was a problem hiding this comment.
I'm actually not sure if this will provide any more info. I think the backups are being created they just don't contain anything.
Collaborator
Author
There was a problem hiding this comment.
From stackdriver logs, it does seem like directory has corpus units, so this is just to see what arguments are passed to shutil.make_archive. something very weird, so this is just to log and confirm the arguments and size of archive locally.
Collaborator
Author
|
/gcbrun |
inferno-chromium
added a commit
that referenced
this pull request
Apr 15, 2019
This reverts commit 1360010.
inferno-chromium
added a commit
that referenced
this pull request
Apr 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.