Enable deploying chrome-tests-syncer independently #4675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decouple the chrome-tests-syncer code releases from the rest of clusterfuzz, in order to enable it to be deployed independently of the clusterfuzz instances by the chrome fuzzing team . * Extended the butler deploy script to produce a dedicated deployment package for "--release=chrome-tests-syncer" and to produce both the prod and tests-syncer packages when releasing to prod. * Changed chrome-tests-syncer Dockerfile/start.sh to pull from this dedicated deployment package. * Moved and edited the tests-syncer code to be executed as a k8s cronjob. * (side effect) Updated unit test to account for deploying the chrome-tests-syncer manifest. * Deployed a chrome-tests-syncer release using this PR and produced the dedicated artifact (https://screenshot.googleplex.com/8W88DmYwFKPkSfZ.png). * Built an updated chrome-tests-syncer image that pulls from this artifact (https://screenshot.googleplex.com/8HqEvV7bnBggBPj.png). * Created the chrome-tests-syncer cronjob (along with PR in clusterfuzz-config: 2428107) pulling from this updated image, applied it to the GKE and it ran successfully:  * Mocked a deployment with --release=prod (by printing the command instead of actually uploading to gcs): <img width="960" alt="Screenshot 2025-02-05 at 11 48 31" src="https://github.com/user-attachments/assets/bd035374-07d1-453a-9db4-2ed0cd39d92f" /> Bug: b/389048599
vitorguidi
approved these changes
Feb 10, 2025
Collaborator
vitorguidi
left a comment
vitorguidi
left a comment
There was a problem hiding this comment.
lgtm, already tested on top of master
ViniciustCosta
added a commit
that referenced
this pull request
Feb 10, 2025
Fix a bug inserted in #4675, which was deleting the manifest file before uploading it to the GCP during deployment.
ViniciustCosta
added a commit
that referenced
this pull request
Feb 10, 2025
Fix a bug inserted in #4675, which was deleting the manifest file before uploading it to the GCP during deployment.
vitorguidi
pushed a commit
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from of #4647 into
chromebranch.