[Logging] Truncate extras when dumped as a string in labels#4852
Merged
Conversation
ViniciustCosta
changed the title
vitaliset
approved these changes
Jun 30, 2025
vitorguidi
approved these changes
Jun 30, 2025
javanlacerda
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: As commented in other PRs (#4845, #4752), we have a recurring issue with oversized logs.
This PR adds the truncate method in another part of the code, where the
extrasfield from python logging is dumped as a json string in the labels from GCP logging. I'm not sure if this label is useful and/or being used anymore, but to avoid removing for now, just inserting the truncate function after doing thejson.dumpsis enough.This can be done because the value in labels is not interpreted as a json by the GCP logging afterward, but as a raw string, as seen here: https://screenshot.googleplex.com/8RG3K5aryJsjudm.png
b/414397533