[Tracing] Instrument code to emit Task Execution events#4860
Merged
Conversation
vitaliset
approved these changes
Jul 8, 2025
vitorguidi
reviewed
Jul 8, 2025
vitorguidi
reviewed
Jul 8, 2025
vitorguidi
reviewed
Jul 10, 2025
vitorguidi
approved these changes
Jul 10, 2025
vitorguidi
reviewed
Jul 10, 2025
| """Task status.""" | ||
| STARTED = 'started' | ||
| FINISHED = 'finished' | ||
| MAIN_FINISHED = 'main_finished' |
Collaborator
Author
There was a problem hiding this comment.
Sorry, I merged this before seeing this comment. It is not being used, I'll remove in a further PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR instruments the code to emit
TaskExecutionEvents(defined at #4857) during utasks execution (events for trusted tasks will be added in a next PR).The implementation leverages the
_MetricRecorderfrom utasks module, since it already wraps the execution of all task stages while also storing important metadata from the task. This enables us sending events with context for each stage, even if unhandled exceptions happen during runtime.Events are emitted in the following cases:
Event: {TaskStatus=Exception, Outcome=Unhandled exception}Event: {TaskStatus=Exception, Outcome=No preprocess return}Event: {TaskStatus=Started, Outcome=None}Event: {TaskStatus=Postprocess Started, Outcome=<uworker_output.error_type>}Event: {TaskStatus=Exception, Outcome=Unhandled exception}Event: {TaskStatus=Postprocess Completed, Outcome=<uworker_output.error_type>}Notice that a known limitation is that we do not send events from utask main, since we currently don't have a workaround to access datastore from untrusted workers.
b/394059581
Tests
Unit tests were added to verify all the instrumented codepaths and check the correctness of the events being emitted.
Runtime tests were done by deploying to dev environment.