MiraclePtr-protected crashes are not security issues.#4906
Merged
ViniciustCosta merged 1 commit intogoogle:masterfrom Aug 18, 2025
Merged
Conversation
ArthurSonzogni
force-pushed
the
miracle-ptr-protected-tag-issue
branch
from
197f082 to
575e7b0
Compare
Contributor
Author
|
/gcbrun |
ArthurSonzogni
force-pushed
the
miracle-ptr-protected-tag-issue
branch
from
575e7b0 to
d8a943f
Compare
Contributor
Author
|
/gcbrun |
ArthurSonzogni
force-pushed
the
miracle-ptr-protected-tag-issue
branch
2 times, most recently
from
3d9423d to
f3505ad
Compare
Contributor
|
/gcbrun |
alhijazi
approved these changes
Aug 12, 2025
As of M128, if a bug is marked MiraclePtr Status:PROTECTED, it is not considered a security issue. It should be converted to type:Bug and assigned to the appropriate engineering team as functional issue. This patch moves the MiraclePtr detection logic from `issue_filer.py` to `crash_analyzer.py` and uses it to correctly classify MiraclePtr-protected crashes as non-security issues. Fixed:google#4903 Fixed:https://crbug.com/40930527
ArthurSonzogni
force-pushed
the
miracle-ptr-protected-tag-issue
branch
from
f3505ad to
b3bd51e
Compare
alhijazi
approved these changes
Aug 13, 2025
Contributor
|
/gcbrun |
Contributor
Author
|
I would like to discuss bug visibility before landing this patch. Please wait before merging. |
Contributor
Author
We agreed this was the right call. This patch is ready. |
javanlacerda
approved these changes
Aug 18, 2025
Collaborator
javanlacerda
left a comment
javanlacerda
left a comment
There was a problem hiding this comment.
LGTM. As I don't have context about MicraclePtr, it would be great wait for a review from another person that have it.
Collaborator
|
@alhijazi has the context and approved the PR already. |
Collaborator
Great! |
Contributor
Author
|
Thanks! As I am not part of this github repository, I would need someone to click the button to apply this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of M128, if a bug is marked MiraclePtr Status:PROTECTED, it is not considered a security issue. It should be converted to type:Bug and assigned to the appropriate engineering team as functional issue.
This patch moves the MiraclePtr detection logic from
issue_filer.pytocrash_analyzer.pyand uses it to correctly classify MiraclePtr-protected crashes as non-security issues.Fixed:#4903
Fixed:https://crbug.com/40930527