Also install future in Windows startup script.#492
Conversation
|
Also, what's the proper way to install this on our macOS machines these days? |
|
actually why do we need in startup script ? we have this src/requirements.txt for bots and we set pythonpath very early at start. do we have other scripts like docker ones that need future (e.g. 4bf8622) |
|
This is just to make it safer to run the remainder of the fixers, which will be adding a lot of these future imports. For instance, I'm not even sure how https://github.com/google/clusterfuzz/blob/master/src/python/bot/startup/run_bot.py#L20 works right now, because it happens before the Having this installed on the CI but not the base bot images is also a mismatch that would hide issues. |
|
ah right, i think all these builtins import should be moved after fix_module_search_paths for safety and to work across mac, android bots. and might have to be careful on run.py and run_heartbeat too. good to have in base image and windows, so lgtm. |
No description provided.