Skip to content

Adds Feature Flag for Swarming tasks#5185

Closed
IvanBM18 wants to merge 4 commits intomasterfrom
feature/swarming_feature_flag
Closed

Adds Feature Flag for Swarming tasks#5185
IvanBM18 wants to merge 4 commits intomasterfrom
feature/swarming_feature_flag

Conversation

@IvanBM18
Copy link
Collaborator

@IvanBM18 IvanBM18 commented Mar 2, 2026

Adds a Feature flag so that we are able to control wether tasks in swarming will be able to be triggered or not trough an external value.

@IvanBM18 IvanBM18 self-assigned this Mar 2, 2026
@IvanBM18 IvanBM18 changed the title Adds Feature Branch for Swarming tasks Adds Feature Flag for Swarming tasks Mar 2, 2026
Copy link
Collaborator

@javanlacerda javanlacerda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide evidence that it's working in dev? As dev is not sync with master, you will probably need to have a commit that combines your implementation with this fix, and then cherry-pick it over dev.

@IvanBM18
Copy link
Collaborator Author

IvanBM18 commented Mar 3, 2026

Could you provide evidence that it's working in dev? As dev is not sync with master, you will probably need to have a commit that combines your implementation with this fix, and then cherry-pick it over dev.

Added some logs to dev env And here's a screenshot of some logs of tasks in dev that show the feature flag as false:
image

Copy link
Collaborator

@letitz letitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you need a test :)

Copy link
Collaborator

@javanlacerda javanlacerda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to test the entire implementation that regards swarming tasks with feature flag in dev and then provide evidence that even with the new code, we don't have any new error group.

@IvanBM18 IvanBM18 requested a review from a team as a code owner March 3, 2026 17:02
@IvanBM18
Copy link
Collaborator Author

IvanBM18 commented Mar 3, 2026

Closing this one since we are doing a full rollback on the swarming changes ill send it back again later when we are sure the changes are healthy and ready

@IvanBM18 IvanBM18 closed this Mar 3, 2026
@jardondiego
Copy link
Collaborator

Closing this one since we are doing a full rollback on the swarming changes ill send it back again later when we are sure the changes are healthy and ready.

I think it would make sense to keep this to help protect future releases. I think we should re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants