Update FATAL_ERROR_REGEX to support missing file/line information#5226
Update FATAL_ERROR_REGEX to support missing file/line information#5226ViniciustCosta merged 4 commits intogoogle:masterfrom
Conversation
V8 changed fatal error messages to skip file and line information if they are not set (see https://crrev.com/c/7705483). This change updates the FATAL_ERROR_REGEX in ClusterFuzz to correctly parse these messages when the file/line part is missing. Added a test case and corresponding test data to verify the fix.
|
Another little fix necessary after https://crrev.com/c/7705483. @ViniciustCosta can you PTAL? |
vitaliset
left a comment
vitaliset
left a comment
There was a problem hiding this comment.
CI is red. Otherwise, LGTM. Can you fix it?
As I don't have much knowledge on the V8 stack analyzer, I can merge to unblock you after fixing the tests (the k8s e2e test fail you can ignore it, we are aware of it). For these cases, I think you can probably ask for someone from your team (likely @mi-ac ) to actually review if needed. |
|
Oh, thanks, didn't see the failure among all the usual redness here. Let's see if this looks better now. |
Yeah, I can add Michael next time. This is a pretty straight-forward and uncontroversial change though. |
|
/gcbrun |
|
Tests seem to pass now. Feel free to squash&merge. Thanks! |
3 participants
V8 changed fatal error messages to skip file and line information if they are not set (see https://crrev.com/c/7705483). This change updates the FATAL_ERROR_REGEX in ClusterFuzz to correctly parse these messages when the file/line part is missing.
Added a test case and corresponding test data to verify the fix.