Protect testcase task-log downloads#5243
Merged
decoNR merged 4 commits intogoogle:masterfrom Apr 15, 2026
Merged
Conversation
decoNR
requested changes
Apr 14, 2026
Contributor
|
Please fix lint errors (ref: Run basic tests / build (pull_request)). |
Contributor
|
/gcbrun |
Contributor
Author
|
Addressed the review about the unnecessary cast. The handler now passes the raw |
decoNR
requested changes
Apr 14, 2026
Contributor
|
/gcbrun |
decoNR
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a clean replacement for #5214 with only the task-log fix and its focused tests.
It adds testcase access checks before returning task logs and quotes task log filter values before building the Cloud Logging query so user-controlled task parameters cannot alter the intended filter constraints.
Verification: