Swarming: Tag metrics with swarming runtime.#5248
Merged
Conversation
jardondiego
reviewed
Apr 22, 2026
jardondiego
reviewed
Apr 22, 2026
jardondiego
reviewed
Apr 22, 2026
jardondiego
reviewed
Apr 28, 2026
IvanBM18
commented
Apr 28, 2026
| _default_extras = {} | ||
|
|
||
|
|
||
| def _is_running_on_k8s(): |
Collaborator
Author
There was a problem hiding this comment.
Now that we dont have a circular dependency we can start using the same method that its declared on environment.py
IvanBM18
commented
Apr 28, 2026
| os.getenv('SERVER_SOFTWARE', '').startswith('Development/')) | ||
|
|
||
|
|
||
| def _is_running_on_app_engine(): |
Collaborator
Author
There was a problem hiding this comment.
Same as above:
Now that we dont have a circular dependency we can start using the same method that its declared on environment.py
Collaborator
|
It looks like we have failing tests. Can you take a look? |
letitz
approved these changes
Apr 30, 2026
Collaborator
letitz
left a comment
There was a problem hiding this comment.
LGTM % nits.
Can you adjust the PR title? It does not describe what the change fixes. How about "Swarming: tag fuzzing hours metrics with correct runtime."?
javanlacerda
approved these changes
May 4, 2026
Collaborator
javanlacerda
left a comment
There was a problem hiding this comment.
LGTM! Single question I have is if with this changes, the fuzzing hours for swarming are with the swarming label?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if we run fuzzing sessions on swarming, the metrics dont seem to register those fuzzing hours correctly:

Note that the swarming fuzzing hours appear as empty:
runtime=logs<->environmentmodules, i removed some methods that were previously declared twice to avoid said circular dependency, now they are correctly imported from a single moduleTests performed
Changes present in dev since before the last
devbranch reset(which is around 22th of April).Worth noting error logs in
devenv:Heres a list of logs that came to my attention:
There is a recurring PERMISSION_DENIED exception in the testcase_manager.py. It specifically points to "Missing or insufficient permissions" when calling the Datastore API via gRPC.
Not related since we are not making any changes nor to auth or to the data store api.
A weird error group, seems related to missing permissions or mismatch across service accounts, may be worth looking, or may come from other tests that someone is performing in dev