[BlackboxBenchmarking] Adds return True for aggregate fuzzer stats cron#5274
Merged
Conversation
dylanjew
changed the title
aakallam
approved these changes
May 13, 2026
Comment on lines
+75
to
+76
| result = aggregate_fuzzer_stats.main() | ||
| self.assertTrue(result) |
Collaborator
There was a problem hiding this comment.
Nit: combine these lines so that an assertion failure is more descriptive.
Suggested change
| result = aggregate_fuzzer_stats.main() | |
| self.assertTrue(result) | |
| self.assertTrue(aggregate_fuzzer_stats.main()) |
Same with the new self.assertTrue below.
The bots run_cron expects the cron job to return True, otherwise it assumes the script failed if it returns None. This was causing the job to retry multiple times in dev.
dylanjew
force-pushed
the
dylanj/stats-return
branch
from
af06f12 to
eb47f3c
Compare
ViniciustCosta
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bots
run_cronscript expects the cron job'smain()to returnTrue, otherwise it assumes the script failed if it returns None (code). This was causing the job to retry multiple times in dev.logs