Adds support for --no-streaming flag in Android ASan jobs#5332
Merged
Conversation
IvanBM18
force-pushed
the
feature/android-asan-fix
branch
from
56ff10f to
2935808
Compare
Xeicker
approved these changes
Jun 18, 2026
Xeicker
left a comment
Xeicker
left a comment
Collaborator
There was a problem hiding this comment.
Other than the nit LGTM
javanlacerda
approved these changes
Jun 18, 2026
fernandofloresg
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
This PR ensures that Android APKs are installed using the
--no-streamingflag during ASan fuzzing jobs. Modern Android versions default to streaming installation, which prevents the bundled wrap.sh script (responsible for setting up the ASan library environment) from triggering correctly. This change dynamically detects ASan environments and applies the--no-streamingworkaround. We still left intact the legacyasan_device_setup.shlogic in case any otherhaikufuzzer job depends on itFor more details for the
wrap.shscript see the NDK doc and the ASan docsChanges:
app.py: Updated the install method signature to accept and forward additional flags trough**kwargs.device.py: Added a private helper to identify ASan jobs or device environments options, and to then pass the--no-streamingflag during installation.