Fix an exception with 0-size test cases in the viewer handler.#666
Merged
mbarbella-chromium merged 3 commits intomasterfrom Jul 9, 2019
Merged
Fix an exception with 0-size test cases in the viewer handler.#666mbarbella-chromium merged 3 commits intomasterfrom
mbarbella-chromium merged 3 commits intomasterfrom
Conversation
Contributor
Author
|
/gcbrun |
inferno-chromium
approved these changes
Jul 9, 2019
| # https://github.com/googleapis/google-cloud-python/issues/6572 | ||
| if blob_size: | ||
| try: | ||
| content = unicode(blobs.read_key(key), errors='replace') |
Collaborator
There was a problem hiding this comment.
maybe remove this unicode replacement hack along the way and fix https://bugs.chromium.org/p/chromium/issues/detail?id=920160 :) stage to make sure it works.
Contributor
Author
There was a problem hiding this comment.
Seems to cause issues later in template rendering, which I guess explains why we had the hack initially. I'm going to leave it out of this change.
Contributor
Author
|
/gcbrun |
This reverts commit 4220729.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL. We could do a more generic fix in storage.read_data but it would require us to check the size in all cases, which seems like it could hurt performance in cases where we don't expect issues. Since we already know the size in the handler this seems like the best quick fix to me, but I'm open to either option.