[Reproduce tool] Serialize fuzz target information along with testcases.#899
Merged
Conversation
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
| """Get FuzzTarget by fully qualified name.""" | ||
| # TODO(mbarbella): This is a fairly brittle hack. Remove it after finding a | ||
| # more general fix for datastore issues with the reproduce tool. | ||
| if environment.get_value('REPRODUCE_TOOL'): |
Collaborator
There was a problem hiding this comment.
This is extremely hacky, @oliverchang any thoughts on how to do this better.
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
PTAL. This has a little bit of code duplication in data_types.py but seems much cleaner overall. |
Contributor
Author
|
/gcbrun |
inferno-chromium
approved these changes
Aug 28, 2019
inferno-chromium
left a comment
inferno-chromium
left a comment
Collaborator
There was a problem hiding this comment.
This is awesome, thanks for doing this.
Contributor
Author
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL. This fixes the recent breakage with the reproduce tool and should allow it to work with any future engines we add. If this seems too hacky it should be possible to modify the calls to these functions to plumb this information in, but we'd still need to serialize it and pass it from the reproduce tool somehow (and the other changes to support this would be fairly invasive). Longer-term, I think we might need a better way to intercept some datastore access, and I think the current solution will make it easier to switch to something that does that later.