This repository was archived by the owner on Sep 19, 2021. It is now read-only.
Conversation
Moved Test from common to Util. Changed the implementation to use Date all the time and not just for converting it to a string. Added the first test for Time to ensure that "fromMs" and "toMs" yielded the same values.
crepricg
reviewed
Apr 3, 2017
Contributor
crepricg
left a comment
crepricg
left a comment
There was a problem hiding this comment.
In the description you refer to a toMs function, but there's no such function in the test.
Contributor
Author
|
Thanks for the catch. It should have been "asMs". |
crepricg
approved these changes
Apr 4, 2017
davjd
added a commit
to davjd/codeu_project_2017
that referenced
this pull request
Jun 26, 2017
Update server.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.