This repository was archived by the owner on Sep 19, 2021. It is now read-only.
Conversation
vaage
reviewed
Apr 10, 2017
| Make sure the client and server are using the same port number. | ||
| You must specify the following startup arguments for `run_server.sh: | ||
| + `<team_id>` and `<team_secret>`: a numeric id for your team, and a secret | ||
| code, which are used to authenticate your server with the Relay server. |
Contributor
There was a problem hiding this comment.
The secrete must be HEX (ie. a string of a-fA-F0-9)
Contributor
Author
There was a problem hiding this comment.
The server takes any string as input, and unless one connects to the Relay the secret is never used. Plus Secret.parse() can handle non-hex characters, so any char out of range will be seen as 0, but I'll add the specs anyway :)
Contributor
There was a problem hiding this comment.
Thanks. Secret.parse really should be changed to throw an IOException.
vaage
reviewed
Apr 10, 2017
| `<team_secret>` when you launch the server in your local setup since it | ||
| will not connect to the Relay server. | ||
| You can specify any integer value for `<team_id>`, and a value expressed | ||
| in hexadecimal format (using numbers `0-9` or letters in the range `A-F`) |
Contributor
There was a problem hiding this comment.
NIT: Should this be 'or' or 'and'?
Contributor
Author
There was a problem hiding this comment.
I think both work. I changed it to and.
vaage
approved these changes
Apr 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the launch instructions in the README.md file to include the cmd line arguments that are now needed.