This repository was archived by the owner on Sep 19, 2021. It is now read-only.
Conversation
Before the relay would only read the teams file at the start-up. This meant that the relay would have to be restarted whenever a new team was added. This change makes the relay reload the teams file every minute so that if a new team is added, they will have access within a minute. This will prevent the relay having to be taken down and losing all its data each time a new team comes on line.
This fixes a compile error for Java 7 where final statements were needed for the reload team data call.
Contributor
Author
|
This change does not affect students so it should be safe to merge to master and release. |
vaage
commented
Apr 13, 2017
| private static void startRelay(Server relay, ConnectionSource source) { | ||
| private static void startRelay(final Server relay, | ||
| final ConnectionSource source, | ||
| final String teamFile) { |
Contributor
Author
There was a problem hiding this comment.
Only 'server' and 'teamFile' actually needed to be final, but I felt it was easier to read if they were all made final. The only side-effect this creates is that you can't re-assign 'source' but it should never be re-assigned anyways.
crepricg
reviewed
Apr 13, 2017
| loadTeamInfo(relay, teamFile); | ||
| LOG.info("Done loading team data."); | ||
|
|
||
| // Add this again in 1 minute so that new entries to the time line will |
Contributor
There was a problem hiding this comment.
Also, I am not sure what this comment is telling me.
The comment about why the loadTeamInfo was adding itself to the timeline made no sense. This corrects the message to be comprehendible.
crepricg
approved these changes
Apr 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the relay would only read the teams file at the start-up. This meant that the relay would have to be restarted whenever a new team was added.
This change makes the relay reload the teams file every minute so that if a new team is added, they will have access within a minute. This will prevent the relay having to be taken down and losing all its data each time a new team comes on line.