fix: stdin shadowing, pre_exec async-signal-safety, fd debug output#55
Merged
qwandor merged 1 commit intogoogle:mainfrom Apr 9, 2026
Merged
fix: stdin shadowing, pre_exec async-signal-safety, fd debug output#55qwandor merged 1 commit intogoogle:mainfrom
qwandor merged 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
=======================================
Coverage 74.40% 74.40%
=======================================
Files 2 2
Lines 211 211
Branches 211 211
=======================================
Hits 157 157
Misses 52 52
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
qwandor
reviewed
Apr 7, 2026
qwandor
reviewed
Apr 7, 2026
qwandor
reviewed
Apr 8, 2026
| println!("pre_exec"); | ||
| list_fds(); | ||
| command.pre_exec(|| { | ||
| eprintln!("pre_exec"); |
Collaborator
There was a problem hiding this comment.
Why eprintln! rather than println! here? And what's wrong with calling list_fds?
qwandor
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.