Remove silenced warnings in book-library exercise #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchiw
changed the title
mgeisler
reviewed
Feb 28, 2023
Expanding the variable makes it ever-so-slightly easier to read.
mgeisler
reviewed
Apr 16, 2023
Comment on lines
+121
to
+123
| for book in library.books { | ||
| println!("{book}"); | ||
| } |
Collaborator
There was a problem hiding this comment.
I just realized that this inadvertently shows the students what they are supposed to write in the print_books method. I'll fix this for the class I'm teaching next week.
NoahDragon
pushed a commit
to wnghl/comprehensive-rust
that referenced
this pull request
Jul 19, 2023
* Update book-library.md * Update book-library.rs * Apply suggestions from code review Expanding the variable makes it ever-so-slightly easier to read. --------- Co-authored-by: Martin Geisler <mgeisler@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In book-library.rs we create instances of the structs (library books) so that the struct fields are not unused. These changes allow us to remove the line to silence warnings for unused variables #71.